net: replace deprecated ip::address_v4::from_string() #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boost::asio::ip::address_v4::from_string() was removed in boost 1.87,
leading to compilation failures:
src/seastar/src/net/ip.cc:44:46: error: no member named 'from_string' in 'boost::asio::ip::address_v4'
auto ipv4 = boost::asio::ip::address_v4::from_string(addr, ec);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
prior to 1.87, the function had been documented as deprecated [1]:
> (Deprecated: Use make_address_v4().)
[1] https://www.boost.org/doc/libs/1_86_0/doc/html/boost_asio/reference/ip__address_v4/from_string.html
Signed-off-by: Casey Bodley <[email protected]>
tchaikov
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
the minimal required boost version in Seastar is 1.73, which contains make_address_v4(), so this change looks good to me.
see also https://www.boost.org/doc/libs/1_73_0/doc/html/boost_asio/reference/ip__address_v4/from_string.html
|
@scylladb/seastar-maint hello maintainers, could you help review this change? without which, seastar is not compatible with boost 1.87. |
Comrade88
pushed a commit
to Comrade88/seastar
that referenced
this pull request
Jan 10, 2025
boost::asio::ip::address_v4::from_string() was removed in boost 1.87,
leading to compilation failures:
src/seastar/src/net/ip.cc:44:46: error: no member named 'from_string' in 'boost::asio::ip::address_v4'
auto ipv4 = boost::asio::ip::address_v4::from_string(addr, ec);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
prior to 1.87, the function had been documented as deprecated [1]:
> (Deprecated: Use make_address_v4().)
[1] https://www.boost.org/doc/libs/1_86_0/doc/html/boost_asio/reference/ip__address_v4/from_string.html
Signed-off-by: Casey Bodley <[email protected]>
Closes scylladb#2610
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boost::asio::ip::address_v4::from_string()was removed in boost 1.87, leading to compilation failures:prior to 1.87, the function had been documented as deprecated: