perf_tests: Right-align numeric metrics in markdown tables #2619
+28
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i am using the test result of #2599 on my machine as an example: without this change
with this change
|
tchaikov
force-pushed
the
perf-test-md-align
branch
from
94ffbb0 to
f6b0d5a
Compare
|
the test failures are tracked by #2620 |
|
It's a shame the test name isn't left-aligned, it's a bit harder to read it that way. |
do you mean the column of "test"? they are. i guess the table in github's markdown is left-aligned by default. |
Right-align metrics columns in markdown output for better number comparison. Previously, metrics were left-aligned in markdown tables but right-aligned in stdout, making it difficult to visually compare numbers. The change adds colons to the right of hyphens in the header row (e.g. `|---:|`) to right-align entire columns. While this affects both headers and data cells, the improved readability of numeric values outweighs the minor tradeoff of right-aligned headers. In short: - Uses `column::print_text` with ":>" alignment for consistent formatting - Maintains existing stdout_printer right alignment - Updates `markdown_printer` alignment to match stdout behavior Signed-off-by: Kefu Chai <[email protected]>
Move print_text_header() into stdout_printer::print_configuration() since it's the only remaining caller. This simplifies the code by reducing function indirection and keeping related functionality together. Signed-off-by: Kefu Chai <[email protected]>
tchaikov
force-pushed
the
perf-test-md-align
branch
from
f6b0d5a to
1b814a1
Compare
|
v2:
|
|
@xemul hi Pavel, could you please take another look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right-align metrics columns in markdown output for better number comparison. Previously, metrics were left-aligned in markdown tables but right-aligned in stdout, making it difficult to visually compare numbers.
The change adds colons to the right of hyphens in the header row (e.g.
|---:|) to right-align entire columns. While this affects both headers and data cells, the improved readability of numeric values outweighs the minor tradeoff of right-aligned headers.In short:
column::print_textwith ":>" alignment for consistent formattingmarkdown_printeralignment to match stdout behavior