Textart4u

[sepandhaghighi]

Reference Issues/PRs

#79

What does this implement/fix? Explain your changes.

• Add 35 new 1-line art
  1. cup1
  2. cup2
  3. gun2
  4. gun3
  5. fish3
  6. fish4
  7. fish5
  8. sword6
  9. sword7
  10. sword8
  11. sword9
  12. knife2
  13. barcode
  14. loading1
  15. loading3
  16. loading4
  17. loading5
  18. loading6
  19. bat2
  20. band aid
  21. mouse2
  22. mouse3
  23. cat3
  24. needle2
  25. rose4
  26. electrocardiogram1
  27. electrocardiogram2
  28. electrocardiogram3
  29. electrocardiogram4
  30. snail2
  31. american money2
  32. american money3
  33. american money4
  34. american money5
  35. cassette2
• gun 1-line art renamed to gun1
• knife 1-line art renamed to knife1
• loading 1-line art renamed to loading2
• bat 1-line art renamed to bat1
• mouse 1-line art renamed to mouse1
• needle 1-line art renamed to needle1
• snail 1-line art renamed to snail1
• american money 1-line art renamed to american money1
• cassette 1-line art renamed to cassette1
• Test system modified (a minor bug in vulture test call)

Any other comments?

After this PR, we will be good to go for next release (version 4.3)

[codecov-io]

Codecov Report

Merging #80 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev      #80   +/-   ##
=======================================
  Coverage   90.79%   90.79%           
=======================================
  Files           1        1           
  Lines         239      239           
  Branches       63       63           
=======================================
  Hits          217      217           
  Misses         19       19           
  Partials        3        3

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f387d21...9b09aa0. Read the comment docs.

[sadrasabouri]

Shouldn't it be something like "████████▒"?

[sadrasabouri]

I think it could be better if we change needle2 text art to needle1, it seems needle2 is more nature than needle1 and it should have priority when the user type "needle" for text art

[sadrasabouri]

I think it could be better if we change needle2 text art to needle1, it seems needle2 is more nature than needle1 and it should have priority when the user type "needle" for text art

[sadrasabouri]

Thank you for your quick response:+1:.

[sepandhaghighi]

Thank you for your quick response👍.

Thanks for your precise review ;-)
We will release next version in next few days.