Check before calling onChange, fixes JedWatson#1988

sevenval · Sep 12, 2017 · 6a7778f · 6a7778f
1 parent bf343fe
commit 6a7778f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/HISTORY.md b/HISTORY.md
@@ -1,5 +1,9 @@
 # React-Select
 
+## Unreleased
+
+* fixed; `Async` component always called `onChange` even when it wasn't provided
+
 ## v1.0.0-rc.8 / 2017-09-12
 
 * fixed; `onMenuScrollToBottom` does not work in chrome 58.0, thanks [Simon Hartcher](https://github.com/deevus)

diff --git a/src/Async.js b/src/Async.js
@@ -66,7 +66,7 @@ export default class Async extends Component {
 			this.loadOptions('');
 		}
 	}
-	
+
 	componentWillUnmount () {
 		this._callback = null;
 	}
@@ -185,7 +185,7 @@ export default class Async extends Component {
 	}
 
 	render () {
-		const { children, loadingPlaceholder, placeholder } = this.props;
+		const { children, loadingPlaceholder, onChange, placeholder } = this.props;
 		const { isLoading, options } = this.state;
 
 		const props = {
@@ -197,7 +197,9 @@ export default class Async extends Component {
 				if (this.props.multi && this.props.value && (newValues.length > this.props.value.length)) {
 					this.clearOptions();
 				}
-				this.props.onChange(newValues);
+				if (typeof onChange === 'function') {
+					onChange(newValues);
+				}
 			}
 		};