Skip to content

Commit

Permalink
update coveralls script and remove babel-register from core depenencies
Browse files Browse the repository at this point in the history
  • Loading branch information
gwyneplaine committed Sep 5, 2017
1 parent fa81280 commit acb2152
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 9 deletions.
12 changes: 6 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
Thanks for your interest in React-Select. All forms of contribution are
welcome, from issue reports to PRs and documentation / write-ups.

* We use node.js v8 for development and testing. Due to incompatibilities with
JSDOM and older versions of node.js, you'll need to use node 4 to run the
tests. If you can't install node v8 as your "default" node installation, you
* We use node.js v4+ for development and testing. Due to incompatibilities with
JSDOM and older versions of node.js, you'll need to use node 4 and above to run the
tests. If you can't install node v4 or above as your "default" node installation, you
could try using [nvm](https://github.com/creationix/nvm) to install multiple
versions concurrently.
* If you're upgrading your node.js 0.x environment, it's sometimes necessary
Expand All @@ -20,7 +20,7 @@ Before you open a PR:
the change is aligned with the project roadmap by opening an issue first,
especially if you're going to spend a lot of time on it.
* In development, run `npm start` to build (+watch) the project source, and run
the [development server](http://localhost:8080).
the [development server](http://localhost:8000).
* Please ensure all the examples work correctly after your change. If you're
adding a major new use-case, add a new example demonstrating its use.
* Please **do not** commit the build files. Make sure **only** your changes to
Expand All @@ -39,7 +39,7 @@ know. We'll help you get started, rather than adding it to the queue.
* Where possible, include tests with your changes, either that demonstrates the
bug, or tests the new functionality. If you're not sure how to test your
changes, feel free to ping @bruderstein
* Run `npm run coveralls` to check that the coverage hasn't dropped, and look at the
* Run `npm run cover` to check that the coverage hasn't dropped, and look at the
report (under the generated `coverage` directory) to check that your changes are
covered
* Please [follow our established coding conventions](https://github.com/keystonejs/keystone/wiki/Coding-Standards)
Expand All @@ -50,5 +50,5 @@ but please ensure there are not more violations than before your changes.
please read our [Documentation Guidelines](https://github.com/keystonejs/keystone/wiki/Documentation-Translation-Guidelines).

* _Make sure you revert your build before submitting a PR_ to reduce the chance
of conflicts. `npm run build` is run after PRs are merged and before any
of conflicts. `gulp build-scripts` is run after PRs are merged and before any
releases are made.
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
"url": "https://github.com/JedWatson/react-select.git"
},
"dependencies": {
"babel-register": "^6.26.0",
"classnames": "^2.2.4",
"prop-types": "^15.5.8",
"react-input-autosize": "^1.1.3"
Expand Down Expand Up @@ -84,7 +83,7 @@
"scripts": {
"build": "nps build",
"cover": "cross-env NODE_ENV=test nyc --reporter=lcov --reporter=text mocha",
"coveralls": "cross-env NODE_ENV=test nyc --reporter=lcov --reporter=text mocha | coveralls",
"coveralls": "cross-env NODE_ENV=test nyc --reporter=lcov --reporter=text mocha && cat coverage/lcov.info | coveralls",
"lint": "eslint .",
"publish:examples": "NODE_ENV=production nps publish",
"start": "webpack-dev-server --progress",
Expand Down
2 changes: 1 addition & 1 deletion webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ module.exports = {
},
devServer: {
contentBase: path.resolve(__dirname, 'examples/src'),
port: 8080,
port: 8000,
},
module: {
rules: [
Expand Down

0 comments on commit acb2152

Please sign in to comment.