Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check mismatching method parameter direction against interface declaration. #5964

Merged
merged 5 commits into from
Dec 31, 2024
Merged

Check mismatching method parameter direction against interface declaration. #5964

merged 5 commits into from
Dec 31, 2024

Conversation

csyonghe
Copy link
Collaborator

Based on PR #5955.

Closes #5962.

@csyonghe csyonghe added the pr: non-breaking PRs without breaking changes label Dec 30, 2024
@csyonghe csyonghe requested a review from a team as a code owner December 30, 2024 19:29
@csyonghe csyonghe changed the title Interface direction Check mismatching method parameter direction against interface declaration. Dec 30, 2024
@csyonghe csyonghe merged commit cc1b96d into shader-slang:master Dec 31, 2024
16 checks passed
@cezneluk cezneluk mentioned this pull request Dec 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleino-nv aleino-nv aleino-nv approved these changes

Assignees
No one assigned
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check arguments direction in interface implementation
2 participants
@csyonghe @aleino-nv