Skip to content

Commit

Permalink
ci: Do not cancel other Selenium jobs (#7463)
Browse files Browse the repository at this point in the history
When we have two jobs queued for FirefoxWindows, for example, we want
one of them to wait, not cancel each other. The only time you would
cancel one is if the other is from the same branch/PR after an update.
Right now, only the browser name is used in the key, so we should never
cancel another job with the same key.

This fix lets us start tests for multiple release PRs at once.
  • Loading branch information
joeyparrish committed Oct 21, 2024
1 parent ceddb1a commit 736c6c8
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/selenium-lab-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ jobs:
# Only one run of this job is allowed at a time, since it uses physical
# resources in our lab.
concurrency: selenium-lab-${{ matrix.browser }}
cancel-in-progress: false

needs: [compute-sha, build-shaka, matrix-config]
strategy:
Expand Down

0 comments on commit 736c6c8

Please sign in to comment.