fix: AD_STARTED fires before ad started with AWS Media Tailor (#5855)

Fixes #5854
shaka-project · Nov 3, 2023 · b39f334 · b39f334
1 parent 508e5cf
commit b39f334
Showing 1 changed file with 14 additions and 3 deletions.
diff --git a/lib/ads/media_tailor_ad_manager.js b/lib/ads/media_tailor_ad_manager.js
@@ -612,8 +612,13 @@ shaka.ads.MediaTailorAdManager = class {
    */
   setupCurrentAdListeners_() {
     const MediaTailorAdManager = shaka.ads.MediaTailorAdManager;
-    this.sendTrackingEvent_(MediaTailorAdManager.IMPRESSION_);
-    this.sendTrackingEvent_(MediaTailorAdManager.START_);
+    let needFirstEvents = false;
+    if (!this.video_.paused) {
+      this.sendTrackingEvent_(MediaTailorAdManager.IMPRESSION_);
+      this.sendTrackingEvent_(MediaTailorAdManager.START_);
+    } else {
+      needFirstEvents = true;
+    }
     this.adListeners_.push({
       target: this.video_,
       type: 'volumechange',
@@ -636,7 +641,13 @@ shaka.ads.MediaTailorAdManager = class {
       target: this.video_,
       type: 'play',
       listener: () => {
-        this.sendTrackingEvent_(MediaTailorAdManager.RESUME_);
+        if (needFirstEvents) {
+          this.sendTrackingEvent_(MediaTailorAdManager.IMPRESSION_);
+          this.sendTrackingEvent_(MediaTailorAdManager.START_);
+          needFirstEvents = false;
+        } else {
+          this.sendTrackingEvent_(MediaTailorAdManager.RESUME_);
+        }
       },
     });
     this.adListeners_.push({