Skip to content

Commit

Permalink
test: Fix recognition of Xbox One in Karma
Browse files Browse the repository at this point in the history 
This updates the UA parser to one that recognizes Xbox devices
including Xbox One.  Corresponds to PR faisalman/ua-parser-js#479

Change-Id: I5e92e78b06c981df1659f73264b6fabfc5eb56ac
  • Loading branch information
@joeyparrish
joeyparrish committed Feb 10, 2021
1 parent d97b09f commit f906570
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"stylelint": "^13.8.0",
"stylelint-config-standard": "^20.0.0",
"tippy.js": "^4.3.1",
"ua-parser-js": "github:joeyparrish/ua-parser-js#develop",
"ua-parser-js": "github:joeyparrish/ua-parser-js#9d154cc",
"which": "^1.3.1"
},
"main": "dist/shaka-player.compiled.js",
Expand Down

2 comments on commit f906570

@avelad
Copy link
Member

@avelad avelad commented on f906570 Feb 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that it will give official support to the Xbox One? (#1705)

@joeyparrish
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, very soon. We're building up the infrastructure for automated testing, and then we have a couple of test failures to address. See also shaka-project/generic-webdriver-server#12 for a look at the tools we're building for it.

Please sign in to comment.