fix: Remove useless deprecation in UITextDisplayer and add some guard…

…s in SimpleTextDisplayer (#7805)

Fixes #7803

lib/player.js

@@ -6554,9 +6554,8 @@ shaka.Player = class extends shaka.util.FakeEventTarget {
       const Platform = shaka.util.Platform;
       if (this.videoContainer_ &&
           (!Platform.safariVersion() || document.fullscreenEnabled)) {
-        const latestConfig = this.getConfiguration();
         return new shaka.text.UITextDisplayer(
-            this.video_, this.videoContainer_, latestConfig.textDisplayer);
+            this.video_, this.videoContainer_);
       } else {
         // eslint-disable-next-line no-restricted-syntax
         if (HTMLMediaElement.prototype.addTextTrack) {

lib/text/simple_text_displayer.js

@@ -91,6 +91,9 @@ shaka.text.SimpleTextDisplayer = class {
    * @export
    */
   append(cues) {
+    if (!this.textTrack_) {
+      return;
+    }
     const flattenedCues = shaka.text.Utils.getCuesToFlatten(cues);
 
     // Convert cues.
@@ -178,6 +181,9 @@ shaka.text.SimpleTextDisplayer = class {
    * @export
    */
   isTextVisible() {
+    if (!this.textTrack_) {
+      return false;
+    }
     return this.textTrack_.mode == 'showing';
   }
 
@@ -186,7 +192,9 @@ shaka.text.SimpleTextDisplayer = class {
    * @export
    */
   setTextVisibility(on) {
-    this.textTrack_.mode = on ? 'showing' : 'hidden';
+    if (this.textTrack_) {
+      this.textTrack_.mode = on ? 'showing' : 'hidden';
+    }
   }
 
   /**

lib/text/ui_text_displayer.js

@@ -8,7 +8,6 @@
 goog.provide('shaka.text.UITextDisplayer');
 
 goog.require('goog.asserts');
-goog.require('shaka.Deprecate');
 goog.require('shaka.log');
 goog.require('shaka.text.Cue');
 goog.require('shaka.text.CueRegion');
@@ -31,9 +30,8 @@ shaka.text.UITextDisplayer = class {
    * Constructor.
    * @param {HTMLMediaElement} video
    * @param {HTMLElement} videoContainer
-   * @param {shaka.extern.TextDisplayerConfiguration} config
    */
-  constructor(video, videoContainer, config) {
+  constructor(video, videoContainer) {
     goog.asserts.assert(videoContainer, 'videoContainer should be valid.');
 
     if (!document.fullscreenEnabled) {
@@ -74,22 +72,12 @@ shaka.text.UITextDisplayer = class {
 
     this.videoContainer_.appendChild(this.textContainer_);
 
-    if (!config || !config.captionsUpdatePeriod) {
-      shaka.Deprecate.deprecateFeature(5,
-          'UITextDisplayer w/ config',
-          'Please migrate to initializing UITextDisplayer with a config.');
-    }
-
-    /** @private {number} */
-    const updatePeriod = (config && config.captionsUpdatePeriod) ?
-       config.captionsUpdatePeriod : 0.25;
-
     /** @private {shaka.util.Timer} */
     this.captionsTimer_ = new shaka.util.Timer(() => {
       if (!this.video_.paused) {
         this.updateCaptions_();
       }
-    }).tickEvery(updatePeriod);
+    }).tickEvery(/* seconds= */ 0.25);
 
     /**
      * Maps cues to cue elements. Specifically points out the wrapper element of

test/test/util/layout_tests.js

@@ -290,9 +290,7 @@ shaka.test.DomTextLayoutTests = class extends shaka.test.TextLayoutTests {
   /** @override */
   recreateTextDisplayer() {
     this.textDisplayer = new shaka.text.UITextDisplayer(
-        /** @type {!HTMLMediaElement} */(this.mockVideo),
-        this.videoContainer,
-        {captionsUpdatePeriod: 0.25});
+        /** @type {!HTMLMediaElement} */(this.mockVideo), this.videoContainer);
     this.textDisplayer.setTextVisibility(true);
   }
 

test/text/ui_text_displayer_unit.js

@@ -51,8 +51,7 @@ describe('UITextDisplayer', () => {
 
   beforeEach(() => {
     video.currentTime = 0;
-    textDisplayer = new shaka.text.UITextDisplayer(
-        video, videoContainer, {captionsUpdatePeriod: 0.25});
+    textDisplayer = new shaka.text.UITextDisplayer(video, videoContainer);
   });
 
   afterEach(async () => {