Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix change timestampOffset on discontinuities when not necessary #7823

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Jan 2, 2025

This change fixes a bug in a Safari test

@avelad avelad changed the title test: Fix GAP in Safari test fix: Fix change timestampOffset on discontinuities when not necessary Jan 2, 2025
@avelad
Copy link
Member Author

avelad commented Jan 2, 2025

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=7823

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround browser: Safari Issues affecting Safari or WebKit derivatives labels Jan 2, 2025
@avelad avelad added this to the v4.13 milestone Jan 2, 2025
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@tykus160 tykus160 merged commit d3238dd into shaka-project:main Jan 3, 2025
36 of 37 checks passed
@avelad avelad deleted the safari-test branch January 3, 2025 08:17
joeyparrish pushed a commit that referenced this pull request Jan 6, 2025
joeyparrish pushed a commit that referenced this pull request Jan 6, 2025
joeyparrish pushed a commit that referenced this pull request Jan 6, 2025
joeyparrish pushed a commit that referenced this pull request Jan 6, 2025
joeyparrish pushed a commit that referenced this pull request Jan 6, 2025
joeyparrish pushed a commit that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser: Safari Issues affecting Safari or WebKit derivatives component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants