Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(WebVTT): Fix rendering of WebVTT in UITextDisplayer #7023

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jul 11, 2024

Fix rendering of align:start and align:end in UITextDisplayer
Fix rendering of position in UITextDisplayer

Fixes #4486

@avelad avelad added type: bug Something isn't working correctly component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround component: WebVTT The issue involves WebVTT subtitles specifically labels Jul 11, 2024
@avelad avelad added this to the v4.11 milestone Jul 11, 2024
@avelad avelad force-pushed the webvtt-text-displayer branch from 7783275 to 1865947 Compare July 11, 2024 11:24
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 75.68%

@avelad avelad merged commit 22a7c49 into shaka-project:main Jul 22, 2024
22 of 30 checks passed
@avelad avelad deleted the webvtt-text-displayer branch July 22, 2024 13:29
avelad added a commit that referenced this pull request Jul 24, 2024
Fix rendering of align:start and align:end in UITextDisplayer
Fix rendering of position in UITextDisplayer

Fixes #4486
avelad added a commit that referenced this pull request Jul 24, 2024
Fix rendering of align:start and align:end in UITextDisplayer
Fix rendering of position in UITextDisplayer

Fixes #4486
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Sep 20, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles component: WebVTT The issue involves WebVTT subtitles specifically priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebVTT position setting not working
3 participants