chore: Improve logging around test setup failures #7344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we fail certain actions during test setup, we should log those unconditionally through Karma's dump() function, and not just when browser console logs are enabled with --enable-logging.
|
Can you fix the lint error? |
avelad
added
the
component: tests
theodab
reviewed
Sep 20, 2024
|
Incremental code coverage: No instrumented code was changed. |
avelad
approved these changes
Sep 20, 2024
avelad
added a commit
that referenced
this pull request
Sep 24, 2024
If we fail certain actions during test setup, we should log those unconditionally through Karma's dump() function, and not just when browser console logs are enabled with --enable-logging. --------- Co-authored-by: Álvaro Velad Galván <[email protected]>
avelad
added a commit
that referenced
this pull request
Sep 24, 2024
If we fail certain actions during test setup, we should log those unconditionally through Karma's dump() function, and not just when browser console logs are enabled with --enable-logging. --------- Co-authored-by: Álvaro Velad Galván <[email protected]>
joeyparrish
added a commit
that referenced
this pull request
Sep 26, 2024
If we fail certain actions during test setup, we should log those unconditionally through Karma's dump() function, and not just when browser console logs are enabled with --enable-logging. --------- Co-authored-by: Álvaro Velad Galván <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we fail certain actions during test setup, we should log those unconditionally through Karma's dump() function, and not just when browser console logs are enabled with --enable-logging.