test: Fix uncaught errors while testing on Cast #7345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We get strange uncaught errors sometimes on Cast devices. These are unreadable "script error" events that have nothing to do with our tests (see https://sentry.io/answers/script-error/), and we intend to ignore them. However, our existing logic to ignore those is not sufficient, because in addition to our own error handler (via window.addEventListener("error")), Jasmine has its own unconditional error handler (via window.onerror). To take complete control over how these are handled, we need to remove Jasmine's handler. Jasmine's handler is installed at the top of its execute() function, so our top-level beforeAll() is the best place to remove it.
|
Incremental code coverage: No instrumented code was changed. |
avelad
approved these changes
Sep 20, 2024
avelad
added
the
component: tests
avelad
pushed a commit
that referenced
this pull request
Sep 24, 2024
We get strange uncaught errors sometimes on Cast devices. These are unreadable "script error" events that have nothing to do with our tests (see https://sentry.io/answers/script-error/), and we intend to ignore them. However, our existing logic to ignore those is not sufficient, because in addition to our own error handler (via window.addEventListener("error")), Jasmine has its own unconditional error handler (via window.onerror). To take complete control over how these are handled, we need to remove Jasmine's handler. Jasmine's handler is installed at the top of its execute() function, so our top-level beforeAll() is the best place to remove it.
avelad
pushed a commit
that referenced
this pull request
Sep 24, 2024
We get strange uncaught errors sometimes on Cast devices. These are unreadable "script error" events that have nothing to do with our tests (see https://sentry.io/answers/script-error/), and we intend to ignore them. However, our existing logic to ignore those is not sufficient, because in addition to our own error handler (via window.addEventListener("error")), Jasmine has its own unconditional error handler (via window.onerror). To take complete control over how these are handled, we need to remove Jasmine's handler. Jasmine's handler is installed at the top of its execute() function, so our top-level beforeAll() is the best place to remove it.
joeyparrish
added a commit
to joeyparrish/shaka-player
that referenced
this pull request
Sep 26, 2024
In shaka-project#7345, we disabled Jasmine's global error handler. However, jasmine still tries to call this. So instead of replacing it with null, replace it with a stub. Also add comments about why we are able to do this and still handle global errors in our own way.
joeyparrish
added a commit
that referenced
this pull request
Sep 26, 2024
In #7345, we disabled Jasmine's global error handler. However, jasmine still tries to call this. So instead of replacing it with null, replace it with a stub. Also add comments about why we are able to do this and still handle global errors in our own way.
joeyparrish
added a commit
that referenced
this pull request
Sep 26, 2024
We get strange uncaught errors sometimes on Cast devices. These are unreadable "script error" events that have nothing to do with our tests (see https://sentry.io/answers/script-error/), and we intend to ignore them. However, our existing logic to ignore those is not sufficient, because in addition to our own error handler (via window.addEventListener("error")), Jasmine has its own unconditional error handler (via window.onerror). To take complete control over how these are handled, we need to remove Jasmine's handler. Jasmine's handler is installed at the top of its execute() function, so our top-level beforeAll() is the best place to remove it.
joeyparrish
added a commit
that referenced
this pull request
Sep 26, 2024
In #7345, we disabled Jasmine's global error handler. However, jasmine still tries to call this. So instead of replacing it with null, replace it with a stub. Also add comments about why we are able to do this and still handle global errors in our own way.
joeyparrish
added a commit
that referenced
this pull request
Sep 26, 2024
In #7345, we disabled Jasmine's global error handler. However, jasmine still tries to call this. So instead of replacing it with null, replace it with a stub. Also add comments about why we are able to do this and still handle global errors in our own way.
joeyparrish
added a commit
that referenced
this pull request
Sep 26, 2024
In #7345, we disabled Jasmine's global error handler. However, jasmine still tries to call this. So instead of replacing it with null, replace it with a stub. Also add comments about why we are able to do this and still handle global errors in our own way.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get strange uncaught errors sometimes on Cast devices. These are unreadable "script error" events that have nothing to do with our tests (see https://sentry.io/answers/script-error/), and we intend to ignore them.
However, our existing logic to ignore those is not sufficient, because in addition to our own error handler (via window.addEventListener("error")), Jasmine has its own unconditional error handler (via window.onerror).
To take complete control over how these are handled, we need to remove Jasmine's handler.
Jasmine's handler is installed at the top of its execute() function, so our top-level beforeAll() is the best place to remove it.