test: Deduplicate platform support check #7450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This deduplicates a platform support check that was run in player_integration.js, and declares the pre-existing central support map in an extern so we can clean up its use. This stops a DRM integration test from timing out on FirefoxWindows. It still gets skipped, though, due to a failing Widevine check, so there will be follow-on work for that. Issue shaka-project#7449
joeyparrish
requested review from
littlespex,
avelad,
JulianDomingo,
theodab and
tykus160
|
Incremental code coverage: No instrumented code was changed. |
|
@shaka-bot test |
|
@avelad: Lab tests started with arguments:
|
avelad
added
the
component: tests
avelad
approved these changes
Oct 21, 2024
joeyparrish
added a commit
that referenced
this pull request
Oct 21, 2024
This deduplicates a platform support check that was run in player_integration.js, and declares the pre-existing central support map in an extern so we can clean up its use. This stops a DRM integration test from timing out on FirefoxWindows. It still gets skipped, though, due to a failing Widevine check, so there will be follow-on work for that. Issue #7449
joeyparrish
added a commit
that referenced
this pull request
Oct 21, 2024
This deduplicates a platform support check that was run in player_integration.js, and declares the pre-existing central support map in an extern so we can clean up its use. This stops a DRM integration test from timing out on FirefoxWindows. It still gets skipped, though, due to a failing Widevine check, so there will be follow-on work for that. Issue #7449
joeyparrish
added a commit
that referenced
this pull request
Oct 21, 2024
This deduplicates a platform support check that was run in player_integration.js, and declares the pre-existing central support map in an extern so we can clean up its use. This stops a DRM integration test from timing out on FirefoxWindows. It still gets skipped, though, due to a failing Widevine check, so there will be follow-on work for that. Issue #7449
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deduplicates a platform support check that was run in player_integration.js, and declares the pre-existing central support map in an extern so we can clean up its use.
This stops a DRM integration test from timing out on FirefoxWindows. It still gets skipped, though, due to a failing Widevine check, so there will be follow-on work for that.
Issue #7449