fix(Ads): Allow play interstitials on iOS fullscreen #7538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
theodab
requested changes
Nov 6, 2024
lib/ads/interstitial_ad_manager.js
Outdated
| /** | ||
| * @private | ||
| */ | ||
| checkSupportForMultipleMediaElements_() { |
There was a problem hiding this comment.
I don't know how happy I am that this method is called checkSupportForMultipleMediaElements_, but the variable that it mutates is called usingBaseVideo_. It seems non-obvious to me.
I can see three possible changes:
- Rename the variable.
usingMultipleMediaElements_? - Rename the method.
determineIfUsingBaseVideo_? - Add a JSDoc description mentioning that this method sets
usingBaseVideo_.
Of those options I feel like 2 is the best, but I could see arguments for 1 or 3.
theodab
approved these changes
Nov 6, 2024
avelad
added a commit
that referenced
this pull request
Nov 12, 2024
avelad
added a commit
that referenced
this pull request
Nov 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.