Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Improve performance when parsing EMSG #7557

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 7, 2024

With the change, we reuse MediaSource's MP4 parsing code to avoid parsing everything twice.
It will also help with the implementation of #7556 in the future.

With the change, we reuse MediaSource's MP4 parsing code to avoid parsing everything twice.
@avelad
Copy link
Member Author

avelad commented Nov 7, 2024

@shaka-bot test

@avelad avelad added the type: performance A performance issue label Nov 7, 2024
@avelad avelad added this to the v4.12 milestone Nov 7, 2024
@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=7557

@avelad avelad merged commit cb66f47 into shaka-project:main Nov 12, 2024
22 checks passed
@avelad avelad deleted the emsg-improvements branch November 12, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: performance A performance issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants