Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Change spellchecking tool and fix spelling mistakes #7765

Merged
merged 18 commits into from
Dec 20, 2024

Conversation

tykus160
Copy link
Member

Fixes #7693

@tykus160 tykus160 added type: code health A code health issue component: build system The issue involves the build system of Shaka Player labels Dec 16, 2024
@tykus160 tykus160 added this to the v4.13 milestone Dec 16, 2024
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this, but it's going to make cherry-picks really interesting for a while.

I've reviewed 38/155 files so far.

demo/asset_card.js Outdated Show resolved Hide resolved
@@ -104,7 +104,7 @@
* discontinuities found between periods. For HLS, it is a number of EXT-X-GAP
* and GAP=YES occurrences. For MSS, it is always set to 0.
* If in src= mode or nothing is loaded, NaN.
* @property {bolean} isLowLatency
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shaka-bot
Copy link
Collaborator

Incremental code coverage: 78.24%

@tykus160 tykus160 merged commit 51765e9 into shaka-project:main Dec 20, 2024
16 of 17 checks passed
@tykus160 tykus160 deleted the wt-cspell branch December 20, 2024 11:27
@joeyparrish
Copy link
Member

Sorry I didn't finish reviewing. Thanks, @avelad, for reviewing so this could get merged, and thanks @tykus160 for all the hard work in correcting so many mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: build system The issue involves the build system of Shaka Player type: code health A code health issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change spell check utility to CSpell
5 participants