chore: Add PlayReady utils #7785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: code health
tykus160
approved these changes
Dec 20, 2024
| @@ -17,6 +17,8 @@ | |||
| +../../lib/deprecate/enforcer.js | |||
| +../../lib/deprecate/version.js | |||
|
|
|||
| +../../lib/drm/playready.js | |||
There was a problem hiding this comment.
If we have drm namespace now, maybe we should move DrmEngine, DrmUtils & FairPlayUtils there? As a separate commit of course.
There was a problem hiding this comment.
Yes, DrmEngine and DrmUtils make sense, FairPlayUtils too, but the problem is that we export that class... so I would need the change to be feat! and we don't want that for now.
There was a problem hiding this comment.
We could move it and bind media.FairplayUtils to drm.FairplayUtils for backward compatibility.
|
Incremental code coverage: 96.36% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.