Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move DrmEngine and DrmUtils to drm namespace #7788

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Dec 20, 2024

No description provided.

@avelad avelad requested a review from tykus160 December 20, 2024 11:38
@avelad avelad added the type: code health A code health issue label Dec 20, 2024
@avelad avelad added this to the v4.13 milestone Dec 20, 2024
Copy link
Member

@tykus160 tykus160 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make require calls in alphabetical order!

lib/drm/drm_engine.js Outdated Show resolved Hide resolved
lib/hls/hls_parser.js Outdated Show resolved Hide resolved
lib/media/manifest_filterer.js Show resolved Hide resolved
@avelad avelad requested a review from tykus160 December 20, 2024 11:51
@avelad avelad merged commit 179ccc6 into shaka-project:main Dec 20, 2024
15 of 18 checks passed
@avelad avelad deleted the drm-namespace branch December 20, 2024 12:11
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 92.94%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: code health A code health issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants