Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Offline): Allow storage of MSS streams #7799

Merged
merged 3 commits into from
Dec 24, 2024
Merged

fix(Offline): Allow storage of MSS streams #7799

merged 3 commits into from
Dec 24, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Dec 23, 2024

No description provided.

@avelad avelad added priority: P1 Big impact or workaround impractical; resolve before feature release component: offline The issue involves the offline storage system of Shaka Player component: MSS The issue involves Microsoft Smooth Streaming manifest format type: bug Something isn't working correctly labels Dec 23, 2024
@avelad avelad added this to the v4.13 milestone Dec 23, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 44.62%

theodab
theodab requested changes Dec 24, 2024
View reviewed changes
lib/offline/download_manager.js Show resolved Hide resolved
lib/offline/download_manager.js Outdated Show resolved Hide resolved
@theodab theodab changed the title fix(Offline): Allow store MSS streams fix(Offline): Allow storage of MSS streams Dec 24, 2024
@avelad avelad requested a review from theodab December 24, 2024 12:37
@avelad avelad requested a review from theodab December 24, 2024 12:41
@avelad avelad merged commit bc41643 into shaka-project:main Dec 24, 2024
17 of 18 checks passed
@avelad avelad deleted the mss-offline branch December 24, 2024 13:08
@shaka-bot shaka-bot mentioned this pull request Dec 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@JulianDomingo JulianDomingo Awaiting requested review from JulianDomingo

@tykus160 tykus160 Awaiting requested review from tykus160

Assignees
No one assigned
Labels
component: MSS The issue involves Microsoft Smooth Streaming manifest format component: offline The issue involves the offline storage system of Shaka Player priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.13
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @shaka-bot @theodab