Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Ads): Apply X-PLAYOUT-LIMIT to entire interstitial #7804

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Dec 24, 2024

Fixes #7782

@avelad avelad added type: bug Something isn't working correctly component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround labels Dec 24, 2024
@avelad avelad added this to the v4.13 milestone Dec 24, 2024
@shaka-bot
Copy link
Collaborator

shaka-bot commented Dec 24, 2024

Incremental code coverage: 70.97%

lib/ads/interstitial_ad_manager.js Outdated Show resolved Hide resolved
@theodab theodab changed the title fix(Ads): Fix X-PLAYOUT-LIMIT for entire interstitial fix(Ads): Apply X-PLAYOUT-LIMIT to entire interstitial Dec 24, 2024
@avelad avelad requested a review from theodab December 24, 2024 12:07
@avelad avelad merged commit e40341c into shaka-project:main Dec 24, 2024
16 of 18 checks passed
@avelad avelad deleted the playout-limit branch December 24, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

X-PLAYOUT-LIMIT for entire interstitial
3 participants