Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove useless calls to isTypeSupported #7817

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Dec 31, 2024

It also enables a test that has been disabled due to this bug.

@avelad
Copy link
Member Author

avelad commented Dec 31, 2024

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=7817

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround labels Dec 31, 2024
@avelad avelad force-pushed the remove-useless-code branch from 0cc236e to 0c73db3 Compare December 31, 2024 14:58
@avelad avelad marked this pull request as draft December 31, 2024 15:26
@avelad avelad added this to the v4.13 milestone Dec 31, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad force-pushed the remove-useless-code branch from 0c73db3 to 8f8f6cb Compare December 31, 2024 15:42
@avelad
Copy link
Member Author

avelad commented Dec 31, 2024

@shaka-bot test

@avelad avelad marked this pull request as ready for review December 31, 2024 15:42
@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=7817

@avelad avelad merged commit bd99632 into shaka-project:main Jan 2, 2025
35 of 39 checks passed
@avelad avelad deleted the remove-useless-code branch January 2, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants