feat: Add adaptation set criteria factory configuration #7886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
changed the title
avelad
added
type: enhancement
gkatsev
force-pushed
the
preference-based-criteria-factory
branch
from
a801891 to
858c2af
Compare
tykus160
approved these changes
Jan 13, 2025
avelad
reviewed
Jan 13, 2025
lib/media/example_based_criteria.js
Outdated
| goog.requireType('shaka.config.CodecSwitchingStrategy'); | ||
|
|
||
|
|
||
| /** | ||
| * @implements {shaka.media.AdaptationSetCriteria} | ||
| * @final | ||
| * @export |
There was a problem hiding this comment.
Closure was complaining about it. Not exactly sure why, though. I would've expected it to work without exporting this one.
Let me try again and report back.
There was a problem hiding this comment.
Well, seems like it's ok without again. Not sure exactly what was up then. Removing the exports.
avelad
reviewed
Jan 13, 2025
| @@ -17,51 +17,33 @@ goog.require('shaka.util.LanguageUtils'); | |||
| /** | |||
| * @implements {shaka.media.AdaptationSetCriteria} | |||
| * @final | |||
| * @export | |||
There was a problem hiding this comment.
Technically I think it is not necessary to export it because it is the default solution.
There was a problem hiding this comment.
ah, yeah, let me double-check if it's still needed. Added it for the same reason as example-based-criteria.
|
Incremental code coverage: 87.39% |
|
@shaka-bot test |
|
@avelad: Lab tests started with arguments:
|
avelad
approved these changes
Jan 13, 2025
tykus160
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exports AdaptationSet, and AdaptationSetCriteria to enable an
adaptationSetCriteriaFactorymethod to allow for shaka users to provide their own implementation of a class that implements AdaptationSetCriteria.Fixes #7768