Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Forbid using dot in generic types #7904

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: Forbid using dot in generic types #7904

wants to merge 1 commit into from

Conversation

tykus160
Copy link
Member

Fixes #2643

Happy reviewing!

@tykus160 tykus160 added type: code health A code health issue priority: P4 Nice to have / wishful thinking component: build system The issue involves the build system of Shaka Player labels Jan 17, 2025
@tykus160 tykus160 added this to the v4.13 milestone Jan 17, 2025
@avelad
Copy link
Member

avelad commented Jan 17, 2025

LGTM, but the merge to other branches will be horrible, I leave the final approval in @joeyparrish's hands :)

@shaka-bot
Copy link
Collaborator

Incremental code coverage: 99.15%

theodab
theodab reviewed Jan 18, 2025
View reviewed changes
Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that some of these changes also add additional spaces. Is that also covered by this change in rules, or was that just something you did while going through?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theodab theodab theodab left review comments

@avelad avelad avelad approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: build system The issue involves the build system of Shaka Player priority: P4 Nice to have / wishful thinking type: code health A code health issue
Projects
None yet
Milestone
v4.13
Development

Successfully merging this pull request may close these issues.

Remove dot in generic types
4 participants
@tykus160 @avelad @shaka-bot @theodab