Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HLS): Fix audio grouping by codec #185

Merged
merged 1 commit into from
Nov 4, 2024
Merged

fix(HLS): Fix audio grouping by codec #185

merged 1 commit into from
Nov 4, 2024

Conversation

joeyparrish
Copy link
Member

Instead of something like this (Packager's default):

#EXT-X-MEDIA:TYPE=AUDIO,URI="aac.m3u8",GROUP-ID="audio",LANGUAGE="en",NAME="aac",DEFAULT=NO,AUTOSELECT=YES,CHANNELS="2"
#EXT-X-MEDIA:TYPE=AUDIO,URI="ac3.m3u8",GROUP-ID="audio",LANGUAGE="en",NAME="ac3",DEFAULT=NO,AUTOSELECT=YES,CHANNELS="2"

#EXT-X-STREAM-INF:BANDWIDTH=973060,AVERAGE-BANDWIDTH=973259,CODECS="avc1.4d401e,mp4a.40.2,ac3",RESOLUTION=846x360,FRAME-RATE=24.000,AUDIO="audio",CLOSED-CAPTIONS=NONE
video.m3u8

We should split the audio groups by codec:

#EXT-X-MEDIA:TYPE=AUDIO,URI="aac.m3u8",GROUP-ID="aac",LANGUAGE="en",NAME="aac",DEFAULT=NO,AUTOSELECT=YES,CHANNELS="2"
#EXT-X-MEDIA:TYPE=AUDIO,URI="ac3.m3u8",GROUP-ID="ac3",LANGUAGE="en",NAME="ac3",DEFAULT=NO,AUTOSELECT=YES,CHANNELS="2"

#EXT-X-STREAM-INF:BANDWIDTH=973060,AVERAGE-BANDWIDTH=973259,CODECS="avc1.4d401e,mp4a.40.2",RESOLUTION=846x360,FRAME-RATE=24.000,AUDIO="aac",CLOSED-CAPTIONS=NONE
video.m3u8

#EXT-X-STREAM-INF:BANDWIDTH=973060,AVERAGE-BANDWIDTH=973259,CODECS="avc1.4d401e,ac3",RESOLUTION=846x360,FRAME-RATE=24.000,AUDIO="ac3",CLOSED-CAPTIONS=NONE
video.m3u8

This can be done in the stream descriptor config for Shaka Packager. Streamer will now always split up audio groups by codec.

@joeyparrish joeyparrish merged commit 7f07eec into shaka-project:main Nov 4, 2024
14 checks passed
@joeyparrish joeyparrish deleted the audio-grouping branch November 4, 2024 19:55
joeyparrish added a commit to joeyparrish/shaka-streamer that referenced this pull request Nov 5, 2024
@joeyparrish
chore: Fix linter error on AudioCodec
ba5bc2a 
Introduced in shaka-project#185
@joeyparrish joeyparrish mentioned this pull request Nov 5, 2024
Merged
joeyparrish added a commit to joeyparrish/shaka-streamer that referenced this pull request Nov 6, 2024
@joeyparrish
chore: Fix linter error on AudioCodec
9bf37fb 
Introduced in shaka-project#185
avelad added a commit that referenced this pull request Nov 6, 2024
@joeyparrish @avelad
chore: Fix linter error on AudioCodec (#188)
d9a3d38 
Introduced in #185

Co-authored-by: Álvaro Velad Galván <[email protected]>
@shaka-bot shaka-bot mentioned this pull request Nov 6, 2024
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jan 3, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avelad avelad avelad approved these changes

@mariocynicys mariocynicys Awaiting requested review from mariocynicys

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeyparrish @avelad