feat: Build locally in Docker to streamline testing #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When making changes to this process, it really helps to have a simple container environment to test changes. This adds a script for a fully-automated build with standard Ubuntu containers to make it easier to check build script changes before deploying them to the repo.
build.sh
Outdated
| # supports Ubuntu as a container, for simplicity. | ||
| if [[ $(id -u) == "0" ]]; then | ||
| # If we're on Ubuntu before 24.04, there's no default "ubuntu" user. | ||
| # This maps these older versions to the starting state of 24.04+. |
There was a problem hiding this comment.
nit; for clarity, specify this is creating a user with a username/password of "ubuntu"
There was a problem hiding this comment.
It's not creating a password at all. That user would be unable to log in with a password. I'll try to clarify the comment.
JulianDomingo
approved these changes
Oct 10, 2024
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making changes to this process, it really helps to have a simple container environment to test changes. This adds a script for a fully-automated build with standard Ubuntu containers to make it easier to check build script changes before deploying them to the repo.