Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Correct versions file path in release workflow #47

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

joeyparrish
Copy link
Member

@joeyparrish joeyparrish commented Oct 10, 2024

This was mistaken ever since we moved the file, but we haven't made any releases since then. The effect of this bug would be to have the "versions" section of the release notes be empty.

@joeyparrish
Copy link
Member Author

This is the last PR blocking a new release here.

Copy link
Member

@mariocynicys mariocynicys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joeyparrish joeyparrish merged commit be43c5e into shaka-project:main Oct 11, 2024
11 checks passed
@joeyparrish joeyparrish deleted the fix-release-versions branch October 11, 2024 16:46
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Dec 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants