feat: Separate Linux static from hardware encoding #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardware acceleration for Linux is too wrapped up in dynamic libraries and drivers, so from now on, builds for Linux that support hardware encoding will be dynamic and will only run on Ubuntu. For use in every other Linux distribution, fully static builds will be done with musl in Alpine Linux.
mariocynicys
approved these changes
Oct 11, 2024
Comment on lines
+35
to
+36
| # OS distribution. | ||
| PLATFORM_CONFIGURE_FLAGS="--enable-vaapi --enable-nvenc" |
There was a problem hiding this comment.
interesting...
didn't nvenc use to be gpl incompatible and thus not re-distributable?
There was a problem hiding this comment.
We are only compiling against these headers from ffmpeg: https://github.com/FFmpeg/nv-codec-headers/blob/master/include/ffnvcodec/nvEncodeAPI.h
So we don't directly link against anything from Nvidia AFAICT.
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardware acceleration for Linux is too wrapped up in dynamic libraries and drivers, so from now on, builds for Linux that support hardware encoding will be dynamic and will only run on Ubuntu. For use in every other Linux distribution, fully static builds will be done with musl in Alpine Linux.
This also updates to the latest release, FFmpeg n7.1.
Closes #10