ci: Restructure release workflow #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isolates elevated permissions to the release publication job only, and simplifies a more complex sequence of creating a draft release, then building and attaching binaries, then compiling release notes, then publishing the release. Now we simply build, compile notes, then publish a full release with notes and binaries at once. This also removes the need for our own "api client" in JavaScript. Now we perform these actions with GitHub's own tools: "gh" command line to create the release and "actions/" official actions to upload and download build artifacts.
|
Validated with a full release on my fork. |
theodab
approved these changes
Dec 18, 2024
This was referenced Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isolates elevated permissions to the release publication job only, and simplifies a more complex sequence of creating a draft release, then building and attaching binaries, then compiling release notes, then publishing the release. Now we simply build, compile notes, then publish a full release with notes and binaries at once.
This also removes the need for our own "api client" in JavaScript. Now we perform these actions with GitHub's own tools: "gh" command line to create the release and "actions/" official actions to upload and download build artifacts.