Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent shimming objects as a function even when objects start with on #15

Closed
wants to merge 1 commit into from

Conversation

gvking
Copy link

@gvking gvking commented Jun 24, 2024

The blink wpt tests are failing when EME logger is enabled due to shimming anything starting with on as a function.
This is fixed by using the js property of object.hasOwnProperty, which only looks at the properties of the object, not the ones that are inherited.

@joeyparrish
Copy link
Member

Discussed with John, and we think the WPT test is at fault. The test checks that all the properties of an object have the "right" types, but it never sets the "on" handlers at all. When a property is null, typeof returns object, so the test expects that they "on" handlers are all objects.

Since the values for those aren't set in the test, it makes no sense to set expectations on their types. They should either be set to functions and checked for function type, or not set and not checked.

@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Nov 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants