ci: Fix workflow events #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was found by auditing workflows based on research published here: https://github.com/joeyparrish/workflow-cheat-sheet The research was prompted by a workflow bug in Shaka Streamer
joeyparrish
requested review from
xhwang-chromium,
gvking,
jrummell-chromium and
beback4u
beback4u
approved these changes
Nov 5, 2024
beback4u
approved these changes
Nov 5, 2024
| - uses: actions/checkout@v2 | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| ref: refs/tags/${{ steps.release.outputs.tag_name }} |
There was a problem hiding this comment.
optional nit: It would be helpful if you put some reason why we need to add this additionally instead of the hyperlink.
There was a problem hiding this comment.
I believe there is a race, since the default ${{ github.ref }} resolves to refs/heads/main. If another change is merged between the release PR and the workflow run, this could check out the wrong thing. Hence the change to an explicit ref built from the release tag name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was found by auditing workflows based on research published here:
https://github.com/joeyparrish/workflow-cheat-sheet
The research was prompted by a workflow bug in Shaka Streamer