Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix RailsContext type #1585

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

kotarella1110
Copy link
Contributor

@kotarella1110 kotarella1110 commented Nov 20, 2023

Summary

Incorrect RailsContext property types have been corrected.

Pull Request checklist

Remove this line after checking all the items here. If the item is not applicable to the PR, both check it out and wrap it by ~.

  • [ ] Add/update test to cover these changes
  • [ ] Update documentation
  • Update CHANGELOG file
    Add the CHANGELOG entry at the top of the file.

Other Information

Remove this paragraph and mention any other important and relevant information such as benchmarks.


This change is Reviewable

@kotarella1110 kotarella1110 force-pushed the fix/fix-RailsContext-type branch from bfac729 to 0917fc2 Compare November 20, 2023 12:59
Copy link
Contributor

@ahangarha ahangarha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏾

Thanks for the PR
Please update the Changelog under Fixes title, under Unreleased version.

@kotarella1110
Copy link
Contributor Author

@ahangarha
Thanks for your review!
Updated: 3e5e30d

@Judahmeek Judahmeek merged commit bd26432 into shakacode:master Nov 21, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants