Upgrade GitHub Actions versions #1623
Conversation
WalkthroughThe recent changes across multiple GitHub workflow files involve updating the versions of the Changes
Poem
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
CHANGELOG.md (1)
21-23: Ensure consistent heading levels for better document structure.- Update outdated GitHub Actions to use Node.js 20.0 versions instead [PR 1623](https://github.com/shakacode/react_on_rails/pull/1623) by [adriangohjw](https://github.com/adriangohjw).Consider changing the heading levels in this section to maintain a logical and hierarchical structure throughout the document.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- .github/workflows/examples.yml (3 hunks)
- .github/workflows/lint-js-and-ruby.yml (2 hunks)
- .github/workflows/main.yml (7 hunks)
- .github/workflows/package-js-tests.yml (2 hunks)
- .github/workflows/rspec-package-specs.yml (2 hunks)
- CHANGELOG.md (1 hunks)
Files skipped from review due to trivial changes (5)
- .github/workflows/examples.yml
- .github/workflows/lint-js-and-ruby.yml
- .github/workflows/main.yml
- .github/workflows/package-js-tests.yml
- .github/workflows/rspec-package-specs.yml
|
@adriangohjw can you investigate the CI failures? |
|
@justin808 alright will do, will look at it sometime this week 🫡 |
|
@adriangohjw any update? |
justin808
changed the title
|
@justin808 sorry for the delay, fixed! |
adriangohjw
changed the title
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- .github/workflows/examples.yml (3 hunks)
- .github/workflows/lint-js-and-ruby.yml (2 hunks)
- .github/workflows/main.yml (8 hunks)
- .github/workflows/package-js-tests.yml (2 hunks)
- .github/workflows/rspec-package-specs.yml (2 hunks)
- CHANGELOG.md (1 hunks)
Files skipped from review due to trivial changes (2)
- .github/workflows/lint-js-and-ruby.yml
- .github/workflows/package-js-tests.yml
Additional context used
Markdownlint
CHANGELOG.md
18-18: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
18-18: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
21-21: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
26-26: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
22-22: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
Additional comments not posted (29)
.github/workflows/rspec-package-specs.yml (5)
38-40: Upgrade GitHub Actions version: cache@v4The
actions/cacheversion has been upgraded fromv3tov4. Ensure that the new version is compatible with the existing workflow and that it aligns with the migration guide.
53-55: Upgrade GitHub Actions version: upload-artifact@v4The
actions/upload-artifactversion has been upgraded fromv3tov4. Ensure that the new version is compatible with the existing workflow and that it aligns with the migration guide.
55-56: Update artifact naming conventionThe artifact name has been updated to include dynamic values such as
github.run_id,github.job, andmatrix.versions. This change ensures unique artifact names for each run, improving traceability and avoiding conflicts.
58-60: Upgrade GitHub Actions version: upload-artifact@v4The
actions/upload-artifactversion has been upgraded fromv3tov4. Ensure that the new version is compatible with the existing workflow and that it aligns with the migration guide.
60-61: Update artifact naming conventionThe artifact name has been updated to include dynamic values such as
github.run_id,github.job, andmatrix.versions. This change ensures unique artifact names for each run, improving traceability and avoiding conflicts..github/workflows/examples.yml (5)
38-40: Upgrade GitHub Actions version: setup-node@v4The
actions/setup-nodeversion has been upgraded fromv3tov4. Ensure that the new version is compatible with the existing workflow and that it aligns with the migration guide.
54-56: Upgrade GitHub Actions version: cache@v4The
actions/cacheversion has been upgraded fromv3tov4. Ensure that the new version is compatible with the existing workflow and that it aligns with the migration guide.
59-61: Upgrade GitHub Actions version: cache@v4The
actions/cacheversion has been upgraded fromv3tov4. Ensure that the new version is compatible with the existing workflow and that it aligns with the migration guide.
91-93: Upgrade GitHub Actions version: upload-artifact@v4The
actions/upload-artifactversion has been upgraded fromv3tov4. Ensure that the new version is compatible with the existing workflow and that it aligns with the migration guide.
93-94: Update artifact naming conventionThe artifact name has been updated to include dynamic values such as
github.run_id,github.job, andmatrix.versions. This change ensures unique artifact names for each run, improving traceability and avoiding conflicts..github/workflows/main.yml (19)
29-31: Upgrade GitHub Actions version: setup-node@v4The
actions/setup-nodeversion has been upgraded fromv3tov4. Ensure that the new version is compatible with the existing workflow and that it aligns with the migration guide.
45-47: Upgrade GitHub Actions version: cache@v4The
actions/cacheversion has been upgraded fromv3tov4. Ensure that the new version is compatible with the existing workflow and that it aligns with the migration guide.
56-58: Upgrade GitHub Actions version: cache@v4The
actions/cacheversion has been upgraded fromv3tov4. Ensure that the new version is compatible with the existing workflow and that it aligns with the migration guide.
65-67: Upgrade GitHub Actions version: cache@v4The
actions/cacheversion has been upgraded fromv3tov4. Ensure that the new version is compatible with the existing workflow and that it aligns with the migration guide.
78-80: Upgrade GitHub Actions version: cache/save@v4The
actions/cache/saveversion has been upgraded fromv3tov4. Ensure that the new version is compatible with the existing workflow and that it aligns with the migration guide.
100-102: Upgrade GitHub Actions version: setup-node@v4The
actions/setup-nodeversion has been upgraded fromv3tov4. Ensure that the new version is compatible with the existing workflow and that it aligns with the migration guide.
116-118: Upgrade GitHub Actions version: cache@v4The
actions/cacheversion has been upgraded fromv3tov4. Ensure that the new version is compatible with the existing workflow and that it aligns with the migration guide.
121-123: Upgrade GitHub Actions version: cache@v4The
actions/cacheversion has been upgraded fromv3tov4. Ensure that the new version is compatible with the existing workflow and that it aligns with the migration guide.
126-128: Upgrade GitHub Actions version: cache@v4The
actions/cacheversion has been upgraded fromv3tov4. Ensure that the new version is compatible with the existing workflow and that it aligns with the migration guide.
131-133: Upgrade GitHub Actions version: cache@v4The
actions/cacheversion has been upgraded fromv3tov4. Ensure that the new version is compatible with the existing workflow and that it aligns with the migration guide.
138-140: Upgrade GitHub Actions version: cache@v4The
actions/cacheversion has been upgraded fromv3tov4. Ensure that the new version is compatible with the existing workflow and that it aligns with the migration guide.
182-184: Upgrade GitHub Actions version: upload-artifact@v4The
actions/upload-artifactversion has been upgraded fromv3tov4. Ensure that the new version is compatible with the existing workflow and that it aligns with the migration guide.
184-185: Update artifact naming conventionThe artifact name has been updated to include dynamic values such as
github.run_id,github.job, andmatrix.versions. This change ensures unique artifact names for each run, improving traceability and avoiding conflicts.
187-189: Upgrade GitHub Actions version: upload-artifact@v4The
actions/upload-artifactversion has been upgraded fromv3tov4. Ensure that the new version is compatible with the existing workflow and that it aligns with the migration guide.
189-190: Update artifact naming conventionThe artifact name has been updated to include dynamic values such as
github.run_id,github.job, andmatrix.versions. This change ensures unique artifact names for each run, improving traceability and avoiding conflicts.
192-194: Upgrade GitHub Actions version: upload-artifact@v4The
actions/upload-artifactversion has been upgraded fromv3tov4. Ensure that the new version is compatible with the existing workflow and that it aligns with the migration guide.
194-195: Update artifact naming conventionThe artifact name has been updated to include dynamic values such as
github.run_id,github.job, andmatrix.versions. This change ensures unique artifact names for each run, improving traceability and avoiding conflicts.
197-199: Upgrade GitHub Actions version: upload-artifact@v4The
actions/upload-artifactversion has been upgraded fromv3tov4. Ensure that the new version is compatible with the existing workflow and that it aligns with the migration guide.
199-200: Update artifact naming conventionThe artifact name has been updated to include dynamic values such as
github.run_id,github.job, andmatrix.versions. This change ensures unique artifact names for each run, improving traceability and avoiding conflicts.
| #### Changed | ||
| - Update outdated GitHub Actions to use Node.js 20.0 versions instead [PR 1623](https://github.com/shakacode/react_on_rails/pull/1623) by [adriangohjw](https://github.com/adriangohjw). |
There was a problem hiding this comment.
Ensure proper formatting of headings and lists.
Headings and lists should be surrounded by blank lines to improve readability and comply with Markdown standards.
### [Unreleased]
#### Changed
- Update outdated GitHub Actions to use Node.js 20.0 versions instead [PR 1623](https://github.com/shakacode/react_on_rails/pull/1623) by [adriangohjw](https://github.com/adriangohjw).
### [14.0.3] - 2024-06-28Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #### Changed | |
| - Update outdated GitHub Actions to use Node.js 20.0 versions instead [PR 1623](https://github.com/shakacode/react_on_rails/pull/1623) by [adriangohjw](https://github.com/adriangohjw). | |
| ### [Unreleased] | |
| #### Changed | |
| - Update outdated GitHub Actions to use Node.js 20.0 versions instead [PR 1623](https://github.com/shakacode/react_on_rails/pull/1623) by [adriangohjw](https://github.com/adriangohjw). | |
| ### [14.0.3] - 2024-06-28 |
Tools
Markdownlint
21-21: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
22-22: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
|
Thanks @adriangohjw |
Summary
Node.js 16 actions are deprecated and we want to update them to use the latest actions
Reference:
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, actions/cache@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.Changes
actions/setup-node@v3toactions/setup-node@v4actions/cache@v3toactions/cache@v4actions/cache/save@v3toactions/cache/save@v4actions/upload-artifact@v3toactions/upload-artifact@v4Uploads are significantly faster, upwards of 90% improvement in worst case scenariosaccording to the documentationPull Request checklist
Remove this line after checking all the items here. If the item is not applicable to the PR, both check it out and wrap it by
~.[ ] Add/update test to cover these changes[ ] Update documentationAdd the CHANGELOG entry at the top of the file.
Other Information
Remove this paragraph and mention any other important and relevant information such as benchmarks.
This change is
Summary by CodeRabbit
setup-node@v4,cache@v4,upload-artifact@v4) for improved performance and security.