Remove config for asset host sensitivity

lib/install/config/shakapacker.yml

@@ -45,9 +45,6 @@ default: &default
   # Select whether the compiler will use SHA digest ('digest' option) or most most recent modified timestamp ('mtime') to determine freshness
   compiler_strategy: digest
 
-  # Set whether the compiler should be sensitive to the provided asset host
-  compiler_strategy_asset_host_sensitive: false
-
   # Select whether the compiler will always use a content hash and not just in production
   # Don't use contentHash except for production for performance
   # https://webpack.js.org/guides/build-performance/#avoid-production-specific-tooling

lib/shakapacker/digest_strategy.rb

@@ -54,13 +54,16 @@ def record_compilation_digest
 
       def compilation_digest_path
         path = "last-compilation-digest-#{Shakapacker.env}"
-        path += "-#{generate_host_hash}" if Shakapacker.config.fetch(:compiler_strategy_asset_host_sensitive)
+        path += "-#{generate_host_hash}" if generate_host_hash.present?
 
         config.cache_path.join(path)
       end
 
       def generate_host_hash
-        @generated_host_hashes ||= {}
+        # Using hash for memoizing the host hash is to make testing easier.
+        # The default value, prevents generating hash in the situation where no value for asset_host
+        # and SHAKAPACKER_ASSET_HOST are provided, leading to not add hash to the asset path.
+        @generated_host_hashes ||= { [nil, nil] => "" }
 
         keys = [Rails.application.config.asset_host, ENV["SHAKAPACKER_ASSET_HOST"]]
 

spec/backward_compatibility_specs/digest_strategy_spec.rb

@@ -9,6 +9,7 @@ def remove_compilation_digest_path
 
   before :all do
     @digest_strategy = Webpacker::DigestStrategy.new
+    ENV["SHAKAPACKER_ASSET_HOST"] = nil
     remove_compilation_digest_path
   end
 

spec/shakapacker/digest_strategy_spec.rb

@@ -29,8 +29,8 @@ def remove_compilation_digest_path
   end
 
   it "is stale when host changes" do
-    allow(Shakapacker.config).to receive(:fetch).with(any_args).and_call_original
-    allow(Shakapacker.config).to receive(:fetch).with(:compiler_strategy_asset_host_sensitive).and_return(true)
+    # allow(Shakapacker.config).to receive(:fetch).with(any_args).and_call_original
+    # allow(Shakapacker.config).to receive(:fetch).with(:compiler_strategy_asset_host_sensitive).and_return(true)
 
     ENV["SHAKAPACKER_ASSET_HOST"] = "the-host"
 
@@ -52,8 +52,8 @@ def remove_compilation_digest_path
   end
 
   it "generates correct compilation_digest_path with " do
-    allow(Shakapacker.config).to receive(:fetch).with(any_args).and_call_original
-    allow(Shakapacker.config).to receive(:fetch).with(:compiler_strategy_asset_host_sensitive).and_return(true)
+    # allow(Shakapacker.config).to receive(:fetch).with(any_args).and_call_original
+    # allow(Shakapacker.config).to receive(:fetch).with(:compiler_strategy_asset_host_sensitive).and_return(true)
 
     ENV["SHAKAPACKER_ASSET_HOST"] = "custom-path"