Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: add the boilplate application.js into packs/ #363

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

layerssss
Copy link
Contributor

@layerssss layerssss commented Sep 28, 2023

shakapaker.yml has source_entry_path: packs instead of / by default.

Summary

I've just bootstraped a new project and installed shakapacker. The default install yields Shakapacker::Manifest::MissingEntryError because application.js is put in app/javascript/ instead of app/javascript/pack/.

Pull Request checklist

Remove this line after checking all the items here. If the item does not apply to the PR, both check it out and wrap it by ~.

  • Add/update test to cover these changes
  • Update documentation
  • Update CHANGELOG file

Other Information

`shakapaker.yml` has `source_entry_path: packs` instead of `/` by default.
@Judahmeek Judahmeek merged commit b52e9a9 into shakacode:master Sep 28, 2023
@layerssss layerssss deleted the patch-1 branch September 28, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants