Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use caching #440

Closed
wants to merge 1 commit into from
Closed

ci: use caching #440

wants to merge 1 commit into from

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Mar 8, 2024

Summary

This attempts to use caching to speed up the dummy and generator workflows - it's hard to completely cache everything since we're testing against so many package managers within the specs themselves, but it should be easy to at least try caching npm and yarn downloads which'll hopefully give some speed up.

Pull Request checklist

  • Add/update test to cover these changes
  • Update documentation
  • Update CHANGELOG file

@G-Rath
Copy link
Contributor Author

G-Rath commented Mar 8, 2024

@tomdracz doesn't seem to have any real impact, which doesn't surprise me - feel free to trigger a re-run to check if follow-up runs are any better

@tomdracz
Copy link
Collaborator

tomdracz commented Mar 9, 2024

Yeah, might not bring much improvement. I've been playing with generator specs here #441 and fair bit of time is spent on installing and fetching all the packages https://github.com/shakacode/shakapacker/actions/runs/8213456703/job/22464895242#step:6:293 ... but fair few of them we already install in setup step so I wondered if pointing at some shared bundler cache would help here.

Granted, might be that some of this slowness is on Ruby itself as for example 3.1 ones are much better https://github.com/shakacode/shakapacker/actions/runs/8213456703/job/22464896090?pr=441#step:6:298 it's just 2.7 that's having trouble. Wonder if part of it is trying to make sense of bundler resolution and failing miserably https://github.com/shakacode/shakapacker/actions/runs/8213456703/job/22464895242?pr=441#step:6:133

Truth be told those specs will be slow as we ran through multiple package managers so maybe it is what it is. #430 should remove at least bits of it which is always a win

@G-Rath
Copy link
Contributor Author

G-Rath commented Mar 9, 2024

Yup that matches what I expect - and to be fair, it's not that slow all things considered; having cancellation helps, and really next is the main one suffering because it gets all the workflows run twice (once for being a pull request and another for being pushed to - I've opened #444 to change this)

@G-Rath
Copy link
Contributor Author

G-Rath commented Mar 9, 2024

btw I'm happy to drop Ruby 2.7 support if you want 🤷

@tomdracz
Copy link
Collaborator

Right, with other improvements, there's probably limited value of caching here, let's drop this PR @G-Rath

@G-Rath G-Rath closed this Mar 10, 2024
@G-Rath G-Rath deleted the use-caching branch March 10, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants