-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OVH Provider #650
base: master
Are you sure you want to change the base?
Add OVH Provider #650
Conversation
hi @shibayan ! do you think you will accept this PR or is OVH to small in your opinion to make it a great addition to your project ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the structure and format of the code should be consistent with other provider implementations. Consistency with other provider implementations must be maintained.
I reordered and rewrote some part of the code to make it looks like GoDaddy provider as much as possible. You were right it's much better like this, thanks ! |
@shibayan it's been a while and i forgot about this PR, could you check if the last version was ok ? thanks ! |
I added OVH which is a cloud / DNS / domain provider really popular in France and at least Europe.
The code is complex because their api is complicated to call with a signature to generate based on the content of the call that needs to be added in header on each requests