Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ORT Model Builder API #24

Merged
merged 5 commits into from
Jan 2, 2025
Merged

Use ORT Model Builder API #24

merged 5 commits into from
Jan 2, 2025

Conversation

huningxin
Copy link
Collaborator

@huningxin huningxin commented Jan 2, 2025 •
edited
Loading

This PR include changes:

  1. Use ORT Model Builder API of Model Builder API microsoft/onnxruntime#23223
  2. Introduce third_party/onnxruntime_headers hosting ORT headers of https://github.com/microsoft/onnxruntime/tree/main/include
  3. Remove ORT headers from third_party/microsoft_headers
  4. Remove the inclusion of onnx.pb.h
  5. Pass ORT_API_VERSION to OrtApiBase::GetApi()
  6. Refactor scoped ORT types ptr

@shiyi9801
Copy link
Owner

LGTM 👍

@mingmingtasd
Copy link
Collaborator

LGTM! 👍

@mingmingtasd mingmingtasd merged commit 2bc8f32 into shiyi9801:ort_backend Jan 2, 2025
@huningxin
Copy link
Collaborator Author

Thanks for review and merging! You may need to build onnxruntime.dll against microsoft/onnxruntime#23223 for testing.

@huningxin
Pass ORT_API_VERSION to OrtApiBase::GetApi()
41b49b0 
Also removes the inclusion of onnx.pb.h header.
@huningxin
Add third_party/onnxruntime_headers
d3b0a77 
Import https://github.com/microsoft/onnxruntime/tree/main/include

Commit is based on microsoft/onnxruntime#23223
@huningxin
Use ORT Model Builder API
a82e8cb
@huningxin
Refactor scoped ORT type ptr
5a11579 
1. Rename to ScopedOrtTypePtr
2. Use macros
3. Introduce `operator T*()`
4. Introduce `Release()` method
5. Rename `get_ptr()` to `Get()`
6. Rename `get_pptr()` to `GetAddressOf()`
@huningxin
Remove ONNX Runtime headers from third_party/microsoft_dxheaders
67f3f6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingmingtasd mingmingtasd mingmingtasd approved these changes

@shiyi9801 shiyi9801 Awaiting requested review from shiyi9801

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huningxin @shiyi9801 @mingmingtasd