Skip to content

Commit

Permalink
fix(github): move github stars to less prominent location (fixes #201)
Browse files Browse the repository at this point in the history
  • Loading branch information
AmitMY committed Jan 21, 2025
1 parent ef8cd35 commit e9d346b
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ <h2>Why use sign.mt?</h2>
</ion-card-title>
<p>{{ t(slide.id + '.subtitle') }}</p>
<p>{{ t(slide.id + '.description') }}</p>
@if (slide.id === 'open-source') {
<br />
<ntkme-github-button user="sign" repo="translate" [count]="true" size="large" />
}
</div>
<div class="graphic">
@switch (slide.id) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,13 @@ import {IonCard, IonCardContent, IonCardTitle, IonIcon} from '@ionic/angular/sta
import {LazyMapComponent} from '../lazy-map/lazy-map.component';
import {addIcons} from 'ionicons';
import {bookOutline, cloudOfflineOutline, languageOutline, optionsOutline, swapHorizontalOutline} from 'ionicons/icons';
import {NtkmeButtonModule} from '@ctrl/ngx-github-buttons';

@Component({
selector: 'app-about-benefits',
templateUrl: './about-benefits.component.html',
styleUrls: ['./about-benefits.component.scss'],
imports: [IonCard, IonCardContent, TranslocoDirective, IonCardTitle, LazyMapComponent, IonIcon],
imports: [IonCard, IonCardContent, TranslocoDirective, IonCardTitle, LazyMapComponent, IonIcon, NtkmeButtonModule],
schemas: [CUSTOM_ELEMENTS_SCHEMA],
})
export class AboutBenefitsComponent extends BaseComponent implements AfterViewInit, OnInit {
Expand Down
1 change: 1 addition & 0 deletions src/app/pages/landing/contribute/contribute.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ <h1>Join Our Efforts</h1>
Our sign language translation app is open source and always improving, but we need your help! By contributing to
the project, you can help make the app more accessible to more users.
</p>
<ntkme-github-button user="sign" repo="translate" [count]="true" size="large" />
</div>

<div class="cards-container">
Expand Down
12 changes: 11 additions & 1 deletion src/app/pages/landing/contribute/contribute.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,22 @@ import {
} from '@ionic/angular/standalone';
import {addIcons} from 'ionicons';
import {alertCircleOutline, code, language} from 'ionicons/icons';
import {NtkmeButtonModule} from '@ctrl/ngx-github-buttons';

@Component({
selector: 'app-contribute',
templateUrl: './contribute.component.html',
styleUrls: ['./contribute.component.scss'],
imports: [IonCard, IonCardHeader, IonCardTitle, IonIcon, IonCardSubtitle, IonCardContent, IonButton],
imports: [
IonCard,
IonCardHeader,
IonCardTitle,
IonIcon,
IonCardSubtitle,
IonCardContent,
IonButton,
NtkmeButtonModule,
],
})
export class ContributeComponent {
cards = [
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
<ion-header [translucent]="true">
<ion-toolbar>
<ion-buttons slot="primary">
<ntkme-github-button user="sign" repo="translate" [count]="true" size="large" />
</ion-buttons>
<ion-buttons slot="secondary">
<ion-button routerLink="/about" queryParamsHandling="preserve" color="light" shape="round" fill="solid">
<ion-button routerLink="/about" queryParamsHandling="preserve" color="primary" shape="round" fill="solid">
{{ 'landing.about.title' | transloco }}
</ion-button>
</ion-buttons>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ import {LogoComponent} from '../../../components/logo/logo.component';
LanguageSelectorsComponent,
SendFeedbackComponent,
TranslocoPipe,
NtkmeButtonModule,
SpokenToSignedComponent,
SignedToSpokenComponent,
DropPoseFileComponent,
Expand Down

0 comments on commit e9d346b

Please sign in to comment.