Log graffiti on validator initialization #6662
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1285,6 +1284,7 @@ impl InitializedValidators { | |||
| "Enabled validator"; | |||
| "signing_method" => "local_keystore", | |||
| "voting_pubkey" => format!("{:?}", def.voting_public_key), | |||
| "graffiti" => format!("{:?}", def.graffiti) | |||
There was a problem hiding this comment.
Just noting that this will only log the graffiti for a validator if it is specified in the validator_definitions.yml, not other sources (e.g. graffiti file).
We're also printing the Debug representation here which will be a bit ugly like None or Some("graffiti"). Instead it would be good to format the None case explicitly and just display the string if it is Some. Something like def.graffiti.map_or("none".to_string(), |graffiti| graffiti.to_string()). You may need to implement Display for GraffitiString.
michaelsproul
added
waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
No related issues found, but this feature was discussed shortly with @michaelsproul here: #6635 (comment)
Proposed Changes
Print out the initial graffiti set to the logs when initializing the validators.
Additional Info
This can help to see if the initial graffiti is set correctly.
I wasn't able to find an easy way to test this, however the test suite are all passing locally.