Fix logic for sync-errors email for when the Google Sheet ID isn't known

silinternational · Oct 2, 2024 · 33a7181 · 33a7181
1 parent 3391eae
commit 33a7181
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/application/common/components/ExternalGroupsSync.php b/application/common/components/ExternalGroupsSync.php
@@ -120,11 +120,15 @@ public static function processUpdates(
             Yii::error($errorSummary);
 
             if (!empty($errorsEmailRecipient)) {
+                $googleSheetUrl = '';
+                if (!empty($googleSheetIdForEmail)) {
+                    $googleSheetUrl = 'https://docs.google.com/spreadsheets/d/' . $googleSheetIdForEmail;
+                }
                 self::sendSyncErrorsEmail(
                     $appPrefix,
                     $errors,
                     $errorsEmailRecipient,
-                    'https://docs.google.com/spreadsheets/d/' . $googleSheetIdForEmail
+                    $googleSheetUrl
                 );
             }
         }