Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 6.7.0 - option to use AppConfig #330

Merged
merged 14 commits into from
Mar 11, 2024
Merged

Release 6.7.0 - option to use AppConfig #330

merged 14 commits into from
Mar 11, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Mar 7, 2024

Added

  • Added an option to use AWS AppConfig to provide configuration values.

Removed

  • Removed signal trap from run.sh since it's no longer effective. The move to AWS CloudWatch logs required Apache to run in the foreground. Gracefully stopping the container is a problem to be solved.

Release PR Checklist

  • Update version number in main.php Sentry configuration

briskt added 14 commits February 23, 2024 09:07
@briskt
Merge remote-tracking branch 'origin/main' into develop
3b7d724
@briskt
set release to 'develop'
659609b
@briskt
use config-shim to load environment variables from AppConfig
8a75b8c
@briskt
remove useless signal trap
6601b6b 
-- it was broken by "-D FOREGROUND" which was required to send logs to CloudWatch
@briskt
add REFRESHED_AT to Dockerfile
29b1990
@briskt
make it backward compatible by checking for presence of APP_ID
7b07484
@briskt
describe AppConfig in README
00362f5
@briskt
remove the -v flag on config-shim to avoid secrets in the log
0013f03
@briskt
add more documentation for AppConfig setup
cc61152
@briskt
update the config-shim URL
d584bfb
@briskt
Merge pull request #329 from silinternational/feature/app-config
847c3c7 
use AWS AppConfig to load environment variables
@briskt
gitignore *.env
44341d0
@briskt
move IMAGE_NAME to top of workflow file
21e0929
@briskt
set release string to 6.7.0
47bb6ee
@briskt briskt requested a review from a team March 7, 2024 18:37
@briskt briskt merged commit c47210b into main Mar 11, 2024
2 checks passed
@briskt briskt deleted the release/6.7.0 branch March 11, 2024 16:19
forevermatt
forevermatt reviewed Mar 18, 2024
View reviewed changes
README.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forevermatt forevermatt forevermatt left review comments

@jason-jackson jason-jackson jason-jackson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@briskt @forevermatt @jason-jackson