Implementation of photoz uncertainties #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @anicola . I'm happy to just merge this seeing as it isn't going to the main branch yet. @eunseongleee I don't know if you just want to have a quick look to make sure nothing is going to break the |
|
Thanks a lot for the heads up @itrharrison and sorry that I'm checking this so late @anicola! I've pushed my latest version just now and hope things won't conflict! From a quick look, it doesn't look like it's gonna conflict, but please let me know if I need to do something about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of photoz uncertainties in the unbinned likelihood. It might still be a bit slow, but I thought I can optimize once we know how slow it is on the sample we will actually be using.