Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the gen attribute support of the context manager hook #5

Merged
merged 76 commits into from
Nov 28, 2023
Merged

Improve the gen attribute support of the context manager hook #5

merged 76 commits into from
Nov 28, 2023

Conversation

TaiSakuma
Copy link
Member

No description provided.

@TaiSakuma
Revert "Remove a comment from awith.py"
6928443 
This reverts commit 9ca86c9.
@TaiSakuma
Update a comment
1797e7d
@TaiSakuma
Merge WithReverse into With
4db8eba
@TaiSakuma
Merge AWithReverse into AWith
f77f619
@TaiSakuma
Clean code
95df02f
@TaiSakuma
Add utils.py
3f7a653
@TaiSakuma
Commit test_scratch_2.py
b9bc129
@TaiSakuma
Replace Exception with BaseException in _fmt_tag()
cfe76b1
@TaiSakuma
Update test_scratch_2.py
adc327d
@TaiSakuma
Move test files to genctxmng/
258a5fc
@TaiSakuma
Add docstrings
39a927e
@TaiSakuma
Clean code
db61fb9
@TaiSakuma
Rename test_scratch_2.py to test_scratch.py
20849be
@TaiSakuma
Commit exc.py, refs.py, and test_refs.py
58bb9b3
@TaiSakuma
Extract stack_with_single() from with_single_context()
fdda695
@TaiSakuma
Extract run_generator_context() from with_single_context()
4545aa8
@TaiSakuma
Rename context() to mock_context()
4fc2d28
@TaiSakuma
Move mock_context() to runner.py
b4da23c
@TaiSakuma
Move run_generator_context() to runner.py
be95e09
@TaiSakuma
Clean code
cbc011e
@TaiSakuma
Add a protocol Stack
e3f2099
@TaiSakuma
Clean code
86e891e
@TaiSakuma
Stop always handling exceptions in mock_context()
ec07a1c
@TaiSakuma
Add exit_stack()
c06d16f
@TaiSakuma
Rename stack_with() to nested_with(), and such
7f06ccb
@TaiSakuma
Add dunder_enter_single()
75bf8dd
@TaiSakuma
Turn refs.py into a package
c030790
@TaiSakuma
Split refs/__init__.py into five files
af9a344
@TaiSakuma
Probe in run_generator_context()
627fc6e
@TaiSakuma
Add nested_with_double()
1f58664
@TaiSakuma
Delete test_with_send_throw.py
bdfb34b
@TaiSakuma
Replace _cm_gen() with stack_gen_ctxs()
b4316b6
@TaiSakuma
Move tests/gen/utils.py to src/apluggy/test.py
c8a1ab6
@TaiSakuma
Test with KeyboardInterrupt
7d1ad1d
@TaiSakuma
Rewrite nested_with_double() and nested_with_triple()
33c3061
@TaiSakuma
Rewrite nested_with_single()
697e07b
@TaiSakuma
Add test_single.py
44d174f
@TaiSakuma
Update nested_with_single() so it passes test_single.py
c76e9c1
@TaiSakuma
Update dunder_enter_single() to match nested_with_single()
4a744b9
@TaiSakuma
Update nested_with_double() and dunder_enter_double()
323622a
@TaiSakuma
Clean code
768e2a5
@TaiSakuma
Clean code in nested_with_double()
7a7aa3e
@TaiSakuma
Clean code in dunder_enter_double()
e82f5e1
@TaiSakuma
Update dunder_enter_triple() and nested_with_triple()
dc1a577
@TaiSakuma
Update dunder_enter_quadruple() and nested_with_quadruple()
5feb9cf
@TaiSakuma
Update stack_gen_ctxs() to match the reference implementations
1c73612
@TaiSakuma
Update mock_context()
9ff2f97
@TaiSakuma
Make nested_with_double() and dunder_enter_double() equivalent
0ad1f2e
@TaiSakuma
Make nested_with_triple() and dunder_enter_triple() equivalent
6c83fea
@TaiSakuma
Make nested_with_quadruple() and dunder_enter_quadruple() equivalent
7e36879
@TaiSakuma
Update stack_gen_ctxs() to match the reference implementations
5fe0849
@TaiSakuma
Add a probe in mock_context()
4b369c4
@TaiSakuma
Remove nested_with_quadruple()
7b1ae0b
@TaiSakuma
Update tests
867d591
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023 •
edited
Loading

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (cd31b92) 90.42% compared to head (147ca29) 95.12%.

Files Patch % Lines
tests/gen/refs/dunder.py 95.16% 8 Missing and 5 partials ⚠️
tests/gen/refs/nested.py 98.08% 2 Missing and 2 partials ⚠️
src/apluggy/gen.py 95.77% 2 Missing and 1 partial ⚠️
tests/gen/runner.py 98.19% 0 Missing and 2 partials ⚠️
tests/gen/refs/types.py 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
+ Coverage   90.42%   95.12%   +4.70%     
==========================================
  Files          13       24      +11     
  Lines         428     1046     +618     
  Branches      100      187      +87     
==========================================
+ Hits          387      995     +608     
- Misses         35       39       +4     
- Partials        6       12       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TaiSakuma TaiSakuma merged commit 2b452de into main Nov 28, 2023
12 of 14 checks passed
@TaiSakuma TaiSakuma deleted the with_single branch November 28, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TaiSakuma @codecov-commenter