Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints to all defs #17

Merged
merged 4 commits into from
Oct 20, 2023
Merged

Add type hints to all defs #17

merged 4 commits into from
Oct 20, 2023

Conversation

TaiSakuma
Copy link
Member

The option disallow_untyped_defs on nextline/ shows no error.
The folder tests/ still contain untyped defs.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (a8e16a3) 86.72% compared to head (57f654a) 86.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   86.72%   86.70%   -0.03%     
==========================================
  Files         112      112              
  Lines        4272     4280       +8     
  Branches      703      704       +1     
==========================================
+ Hits         3705     3711       +6     
- Misses        515      517       +2     
  Partials       52       52              
Files Coverage Δ
nextline/continuous.py 48.07% <100.00%> (ø)
nextline/count.py 100.00% <100.00%> (ø)
nextline/disable.py 70.00% <100.00%> (+3.33%) ⬆️
nextline/fsm/factory.py 100.00% <100.00%> (ø)
nextline/main.py 79.71% <100.00%> (ø)
nextline/plugin/plugins/session/monitor.py 95.91% <100.00%> (ø)
nextline/plugin/plugins/session/spawn.py 100.00% <100.00%> (ø)
nextline/plugin/spec.py 70.11% <100.00%> (ø)
nextline/spawned/call.py 82.35% <100.00%> (+1.10%) ⬆️
nextline/spawned/plugin/plugins/filter.py 62.82% <100.00%> (ø)
... and 22 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TaiSakuma TaiSakuma merged commit a3da610 into main Oct 20, 2023
9 of 10 checks passed
@TaiSakuma TaiSakuma deleted the type branch November 1, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant