Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in speed_rate limitation in wiregrid_actuator/drivers/Actuator.py #579

Merged
merged 8 commits into from
Nov 29, 2023
Merged

Fix bug in speed_rate limitation in wiregrid_actuator/drivers/Actuator.py #579

merged 8 commits into from
Nov 29, 2023

Conversation

sadachi5
Copy link
Contributor

Description

Fix bug in speed_rate limitation in wiregrid_actuator/drivers/Actuator.py for high speed mode.
The limitation was changed from <=1.0 --> <=5.0.

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

BrianJKoopman
BrianJKoopman requested changes Nov 29, 2023
View reviewed changes
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I think we're duplicating efforts with the docs page update. See below comment.

docs/agents/wiregrid_actuator.rst Outdated Show resolved Hide resolved
@BrianJKoopman BrianJKoopman self-requested a review November 29, 2023 15:19
@BrianJKoopman BrianJKoopman merged commit 24a77aa into main Nov 29, 2023
4 checks passed
@BrianJKoopman BrianJKoopman deleted the modify_for_site_wiregrid_actuator branch November 29, 2023 15:20
hnakata-JP pushed a commit that referenced this pull request Apr 12, 2024
@sadachi5 @d-hoshino2626
Fix bug in speed_rate limitation in wiregrid_actuator/drivers/Actuato…
5c0146f 
…r.py (#579)

* update wiregrid_actuator.rst

* add speedrate parameter in insert/eject() in wiregrid_actuator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianJKoopman BrianJKoopman BrianJKoopman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sadachi5 @BrianJKoopman