Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suprsync shouldn't try to copy ignored files #583

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Conversation

jlashner
Copy link
Collaborator

@jlashner jlashner commented Dec 1, 2023

Changes suprsync get_copyable_files so that doesn't include ignored files.

Description

Changes suprsync get_copyable_files so that doesn't include ignored files.

Motivation and Context

We don't want to attempt to copy bad files.

How Has This Been Tested?

Not tested yet

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file handling test is failing, please check the behavior is working properly there.

@BrianJKoopman BrianJKoopman self-requested a review December 5, 2023 18:05
@BrianJKoopman BrianJKoopman merged commit 398147e into main Dec 6, 2023
2 checks passed
@BrianJKoopman BrianJKoopman deleted the suprsync-ignore branch December 6, 2023 15:26
hnakata-JP pushed a commit that referenced this pull request Apr 12, 2024
* Suprsync don't try to copy ignored files

* bugfix

* Ignore flake8 warning in filter

---------

Co-authored-by: Brian Koopman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants