Tes param corrections #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msilvafe
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Jack and I spoke over these changes and he showed me analysis of the results from a new det_cal db he built off of these. I agree that this is ready to merge except for I would like to see the v_thevenin correction test results first before merge. Please share those results when you have them and if there's no big issues feel free to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements functions for more accurate estimations of TES parameters such as resistance, responsivity, and bias power. This is based on @RemingtonGerras's PR (#424), but has been optimized so it runs faster + a few bug fixes. I have built a det-cal database off of results from these functions and they show promising results. Details are on this confluence page.
This includes:
recompute_ivparsfunction, which corrects the existing IV computation by using the proper R_L and V_theveninrun_correctionandrun_corrections_parallelfunctions to compute corrected R_TES and Si based on IVA and BSA objects.to_dictandfrom_dictmethods for IVAnalysis and BiasStepAnalysis object, which is useful to convert a dict representation of the analysis to the analysis object without needing to know the file path.