Putting the mapmaker in the same split convention as the preprocessing #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earosenberg
reviewed
Dec 12, 2024
sotodlib/obs_ops/splits.py
Outdated
There was a problem hiding this comment.
I guess this is more of a belated comment on #1039 (@msilvafe) but I don't like that you must run t2p and hwpss_stats in order for any splits to be possible. This also applies to noiseQ_fit, which is not explicitly checked for. Can we make those optional? Either by silently skipping if they don't exist, or at least making some option in the config?
It would also be nice if requirements on previous preprocess steps were listed in the docstring in preprocess.processes.SplitFlags e.g. to use noise fits you must wrap into "proc_aman.noiseQ_fit" specifically.
earosenberg
requested changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how the mapmaker handles the focal plane splits, so that they follow the same convention as preprocessing.
Also fixes a minor bug in preprocess.